Subtitle Requests
complete
Amrayu78
Enhance the functionality of Subtitle Requests in the following:
- Drama, Movie, and SP (post type pages)
Scenario 1 (no attached SubProjects):
- Show Request Subtitles button until BOTH Japanese & English Sub Projects are associated/linked to a Drama, Movie, or SP
- Keep Adopt Me! button as-is
Scenario 2 (1 attached SubProject):
- If English or Japanese Subtitle Request is fulfilled (not BOTH, just one), show Request Subtitles button for the other language
- Show Adopt Me! button, but the other language in the Sub Project should be pre-selected
Scenario 3 (both attached SubProjects):
- Hide Request Subtitles button once BOTH Japanese & English Sub Projects are associated/linked to a Drama, Movie, or SP
- Hide Adopt Me! button if BOTH Japanese & English Sub Projects are associated/linked
Mockups here:
Amrayu78
complete
Amrayu78
in progress
Amrayu78
complete
Amrayu78
Max Romanchenko: Here's another enhancement request from users. You can work on this after finishing up with the Series enhancements. Lemme know if you have any questions.
Thank you!
Max Romanchenko
Amrayu78: Hi Duong, I'm done. Please make sure everything's okay.
Amrayu78
Max Romanchenko: Hi Max,
I’ve checked out some of it and it looks good. I will do some testing today.
Amrayu78
Max Romanchenko: Hi Max! Some minor fixes. Screenshots attached. Thank you, it looks good!
✅ no subs
- this one looks good.
❌ 1 sub (either english OR japanese only)
Reference: https://drama-otaku.com/drama/ossans-love/
- Include Subtitle Requests numbers still
❌ both subs (english AND japanese)
- Include Subtitle Requests numbers still
Minor cosmetic items for all scenarios:
- Add heading: Subtitle Requests at the top
- Move Subtitle language badge next to title
- In Progress status design - change to match Pirate's Booty Status
- In Progress badge should be after the language badge
Max Romanchenko
Amrayu78: Thanks for the detailed information! I have made the corrections. Please check now.
Amrayu78
Max Romanchenko: I just checked! It all looks good now.
Thank you so much!
Max Romanchenko
Amrayu78: Always happy to help. I have migrated this functionality for Movie and Special pages. Please check it out.
One more question. Do we need an additional tab for SP Projects? It is an additional View that slows down the page, in fact it is a duplication of data. Please let me know what you think about this.
Amrayu78
Max Romanchenko: hi Max,
Thanks, I’ll check movies and SPs in a bit.
Please remove subtitle projects tab if it’s slowing down the page load.
Max Romanchenko
Amrayu78: Let's not delete... At least for now (we can always do that). Maybe you will consult with your team about the necessity of this tab. There is always a workaround if there is really valuable information there.
Amrayu78
Max Romanchenko: Hi Max,
The view is duplicate like you said. I think most people look on the main page to check for the subtitles and they don't check that tab, so I think it's okay to remove it.
Max Romanchenko
Amrayu78: I totally agree with you. I removed that tab from Drama, Movie, Special Pages. Not super winning, but a little cleaner and faster).
Please keep in mind that if we need to have a separate tab for SP, I can write some js code that will duplicate the information from the main tab to the SP tab. This will not slow down the page rendering.
Amrayu78
Max Romanchenko: Thank you! I think it's good like this. :)
Amrayu78
Max Romanchenko: Mare has checked the remaining Sub Requests for Movies and SPs and it looks good! I'll close this out now. Thank you again.