Subtitle Project tab on Dramas, Movies, Specials
complete
Amrayu78
marked this post as
complete
Amrayu78
Max Romanchenko: Another enhancement when you get the chance.
Max Romanchenko
Amrayu78 I think this makes sense and will be convenient for users.
I have a few questions.
- Will the current Subtitle Project on the drama/movie/special page remain the same?
- In the screenshot "Gezan Meshi [SARS-Fansubs]" - is this the title of the project + additional information about the project, right? Should this be displayed as text or as clickable tags?
- Should projects be displayed as an accordion or not?
Amrayu78
Max Romanchenko:
- Yes
- Yes, yes. Text + clickable tags like we already have on the Drama/Movies/Specials pages under Subtitle Availability section.
- No, reveal all.
Max Romanchenko
Amrayu78 I've implemented it. For now (during testing), this tab is only available to administrators. Please check it out.
Amrayu78
Max Romanchenko Thanks for this! I'm still checking on the design.
Also recently we added stream links. Here's such a case:
Can we add these links to the Subtitles tab too?
Some fansubbers will upload the subtitles directly to the site, but some also prefer to host these links as streamable links.
Also I think it would be nice to minimize the subtitles (by project), if there's more than 1.
Let's say a drama has 1 subtitle project: maximize and reveal all
A drama has 3-4 subtitle projects: minimize all of them to let the user select which one they want.
Amrayu78
Max Romanchenko some more design-related feedback.
Also I noticed that Subtitle Projects that are in other Statuses aren't showing like "In Progress" "Announced" "Dropped"
Max Romanchenko
Amrayu78 The problem was this:
if a project had no subtitles uploaded, the code skipped the entire project, even if it had the status "In Progress," "Announced," or "Dropped." (See screenshot.)
I removed this check, and now all projects are displayed in the Subtitles tab.
Max Romanchenko
Amrayu78 I've made some changes and implemented it as a custom accordion. Please check it out.
Regarding the stream links, that is possible. Could you please specify where and how they should be displayed?
Amrayu78
Max Romanchenko Looks good!
Stream links should be displayed under the Subtitles tab as well.
The info should remain the same, and instead of "File Name" we will show Stream Links.
Max Romanchenko
Amrayu78 I've added stream links (if the project has them) to the subtitles table. Since the links are grouped, I've made it a little simpler than in the original "Stream links" tab to avoid "accordion within an accordion." Please check if you are satisfied with this layout.
Amrayu78
Max Romanchenko Yup, it looks good! Thanks.
Amrayu78
Max Romanchenko Sorry Max, some more updates after checking.
Max Romanchenko
Amrayu78 Sure, I made those changes.
Amrayu78
Max Romanchenko this is the final change and we can launch after this.
For stream links, please make the lines gray as well to match the subtitles.
Max Romanchenko
Amrayu78 Sure, I've made those changes and it's now available to logged in users.
Amrayu78
Max Romanchenko Thanks! Looks good. Closing out now.