Oshi Spot New Post Type
complete
Amrayu78
I'd like to expand Oshi Spot out more. This is just the first part of the expansion, I will mock up more to create a user "Map List" feature that is similar to "Watch lists".
- Oshi Spot is treated like a Series.
- 1 Oshi Spot can be associated to many Dramas, Movies, SPs, People, and Groups
I followed the Series template and adjusted it to fit Oshi Spots. Let me know if there's anything that's not possible and we can discuss what makes sense.
Amrayu78
complete
Everything looks good! I will close this out and create a new ticket for the next phase of this feature.
Max Romanchenko
In general terms, I have completed this functionality.
- I completely changed the logic for adding, editing and displaying locations on the drama/movie/special/people/group pages. I also changed some styles for all relationship forms.
- I added a new “Add Oshi Spot” page and put the form on it.
- I created a template for the Oshi Spot page and added all the necessary information and functionality to it.
Please check.
I also have a question. What exactly are the image fields that need to be filled in / displayed? There are a lot of them....(see screenshot).
Second question. The Oshi index page also needs to be improved, right?
Amrayu78
Max Romanchenko: Here's the mockups for Oshi Spot expansion. I am also mocking up something for "Spot List" <-- similar to Watch list but for spots. That'll come later when I have more time.
Max Romanchenko
Amrayu78 Wow thanks for the quick mockup. I have questions.
- From what I understand some fields will now not be stored in the Oshi Spot itself, but inside an intermediate post that links the Oshi Spot and the drama/movie/special/people/group
Here is the list of these fields (please correct me if I'm wrong or missing something):
- Related Episode Number
- Related Episodes Text
- Notes
Is this a correct statement?
- On the mockupI see that Location Shots stay inside the Oshi Spot, right?
- On mockup #3, I see a new Screenshot field. This will be stored separately inside the intermediate post, right? If so, what would the form for adding Oshi Spot to a drama/movie/special/people/group look like?
Amrayu78
Max Romanchenko:
- Yes, some fields will need to be in an intermediary post similar to Series "Classification" or "Cast details - episode number, guest, main, relationship".
Here's the fields:
- Related Episode Number (only applies for Dramas and SPs)
- Related Episodes Text: Let's rename this to "Description", then it can be reused for Dramas, Movies, SPs, People and Groups.
- Notes
- Screenshots: These would be screenshots that are specific to this relationship between Oshi Spot and the Drama, Movie, SP, Person or Group.
- Oshi Spot post will have a gallery of images for itself (added to the Oshi Spot post type); this can be official images. Is it possible to aggregate the screenshots from the intermediary posts and append them in this gallery?
- Correct, new screenshot field will be associated to that relationship between Drama, Movie, SP, Person or Group.
- Drama, Movie, SP - an image from this specific drama that contains this Oshi Spot.
- Person or Group - an image of this person or group at this specific Oshi Spot.
- Adding Oshi Spot to a Drama, Movie, SP, Person, Group: You've already built this on the current setup. Will that work?
Amrayu78
I forgot one tricky thing related to Dramas and SPs since these have "Episodes" associated with them.
1 Oshi Spot can be associated to multiple episodes in 1 Drama or 1 SP.
So we'll need some way to account for the below:
- Episode 1
- Description
- image (can be multiple images from the same episode)
- Episode 2
- Description
- image or images (can be multiples)
Max Romanchenko
Amrayu78 Thanks for the details, I get it, but not all of them, LOL.
I think if we move step by step we will reach the goal.
I'll do what I understand for now and then we'll fix it if something is wrong. I'll update you on my progress.
Thank you.
Amrayu78
Max Romanchenko: Thanks Max! Step by step is the best way. I'm sure we'll reach the goal. Thank you!
Amrayu78
Max Romanchenko: Ah, I understand what you mean by how do people add Oshi Spots to begin with.
Let's do it how we add a Series page.
- A basic page for "Add Oshi Spot" -- this contains the information at the top of the first page of the mockup.
- Users can then go to the Drama, Movie, SP, Person, Group Oshi Spot tab to start associating Oshi Spots already added like cast or crew to a drama page. This is where the intermediary content would be added.
- Then these intermediary posts would appear on the original Oshi Spot page that looks like a Series page.
I'm getting all mixed up. I hope I explained it properly and it makes sense.
Max Romanchenko
Amrayu78 Hi Duong,
I battle with the oshi spot functionality all day long. Especially with the screenshots for each episode.... I've made some progress, but unfortunately Toolset doesn't allow repeater fields for many to many relationships. I can come up with a custom solution, but those fields won't show up in the admin panel. Or the second option is to add one group of fields (episode number + episode text + screenshots) one by one. But this will also require a custom approach, as doesn't does not allow to link several times the same posts. I guess the second option is preferable?
I have another question. Do we need the Note field (see screenshot)? Or do we need it only for movie, group and people pages?
Max Romanchenko
This is what I mean about adding a group of fields one at a time (no “+” next to episodes). If you want to add another episode, you need to do the same thing (search the title, fill in the episode number, text and screenshots). Will this option suit you?
This would require a redesign (again, I only realized this now) as it would mimic the relationship of many to many (with the difference of allowing the same drama to be linked multiple times to the same Oshi Spot)
Amrayu78
Max Romanchenko: Searching for title to add another episode is fine with me. Will this be too complicated?
Amrayu78
Max Romanchenko: We can do the second approach, adding one by one. I think that's fine.
For Notes field, what do you mean only for movie, group, people pages?
We'll only need 1 Notes field for 1 Oshi Spot to 1 Drama, Movie, SP, Group, or Person. Notes is not needed for each episode for example.
Drama, SP - Oshi Spot
Note
- Episode
- Description (for episode)
- Screenshot
Movie, Person, Group - Oshi Spot
Note
- Description
- Screenshot
Max Romanchenko
Amrayu78 Hi Duong, Things get a little more complicated. I think we're a little confused. Once I have a working prototype, it will be easier to finish this, I think.
So far I'm having constant problems with 500 bugs. Can you please add my IP (sent you an email) to the allowed list?
Amrayu78
Max Romanchenko: I've added your IP to cloudflare allow list. There might be some bots attacking the site too which explains the 500 errors.
Max Romanchenko
Amrayu78 Thank you for that!
Max Romanchenko
Amrayu78 Can I ask you to make another mockup please?
What will the Add oshi spot form look like on the drama page? I'm a bit confused as Toolset doesn't allow me complete freedom. It looks like a three level nesting on the Drama page (Drama > Oshi Spot > Oshi spot items) and another nesting on the Oshi Spot page:
Oshi Spot Single Page > Drama > Oshi spot items
I apologize for being too specific, I'm just a bit confused, I want this to work as it should but not overload the site with nested views.
Here's what the form looks like now:
Amrayu78
Max Romanchenko Sure I’ll mock something up in a bit! Sorry this is complicated
Amrayu78
Max Romanchenko: Here's a quick mockup that I created. You are on the right path. I made some notes about the screenshots. If it's too difficult to add this to a related episode, then we can not create a relationship between the Episode and the screenshot.
The screenshots can be separate like they are now, and we can allow users to add alt text in the gallery pop-up. If text is available in this alt text for the image, then overlay it on the image.
Max Romanchenko
Amrayu78 Thank you for your mockup! That's what I originally did. Linking a series of screenshots to an episode in the current architecture is very complicated and requires a separate post with a group of fields.
But then I deleted everything and started to complicate things, trying to create a relationship between the episode and the screenshots...
Now I don't know what to do.
Here's a test drama that uses a separate post for each episode. But it requires adding oshi spot every time. Then using js the episodes are grouped into one if the Oshi spot is the same. I don't know which option to finalize.....
Can you please review and give your opinion?
Max Romanchenko
I think the previous version was better, that is, leave the screenshots without dividing them into episodes. This would make it easier to fill in the information and simplify the structure a bit. I really want to find the best solution for you.
Amrayu78
Max Romanchenko: I agree, let's keep it like it was previously. We can leave the screenshots as-is and not lumping them together with the episodes.
Let me check what you've worked on first.
Amrayu78
Max Romanchenko: Okay, I just checked this and I see what you mean about the complexity and the nesting.
Let's revert it to what it was previously then.
Amrayu78
Max Romanchenko: Here's a mockup.
Max Romanchenko
Amrayu78 Thanks for the mockup. I'll keep working on it.
Max Romanchenko
Amrayu78 Thank you for confirming it. I'm very happy that you are coming up with ever new improvements for the site. But I see that in many ways the site requires a radical improvement of the architecture. I wish I could do everything from scratch, but do we have the energy and time? I hope someday.
Amrayu78
Max Romanchenko: If you are ever up to it, let me know LOL I'll pay you handsomely if you want to re-architect it.
Max Romanchenko
Amrayu78 Thank you! I think that moment will come at some point for sure. I don't remember much of what's been done anymore, LOL, and will have to reinvent everything trying to avoid past mistakes.
The overall goal is:
- Maintain functionality
- Create the possibility of future improvements
- Get rid of all plugins, leave only the indispensable ones, and replace the rest with code
- Improve the pageloading speed .
- Transfer all data into a new format
- Normalize css and js
This will take a lot of time. And these are general tasks. Of course, everything lies in the details... We will definitely come back to this conversation.
Amrayu78
Max Romanchenko: We're on the same page, that's the end goal for the site. To make it easy for maintenance and fast for users. If you want me to mockup specific features, let me know. Most of them are here on canny and we can revisit them.
Max Romanchenko
Amrayu78 Yeah, we'll have to revise everything. Let's keep it in the future for now. Can you create a separate ticket? When you have time.
We'll put everything in there.
Could you reboot the server please? 500 error again.
Amrayu78
Max Romanchenko: Sure, I'll create a new ticket for it so we can track everything. Rebooting the server now.
Amrayu78
Max Romanchenko: I think some bots are killing the site by accessing People pages. This is just based on the trends I'm seeing. Resources run high when multiple people pages are hit. Can you set the People pages back to logged in users only? Block from guests.
Amrayu78
Nevermind, I've blocked people pages from guests in Toolset.
Max Romanchenko
Amrayu78 Yes, I see, thank you.
Amrayu78
Max Romanchenko: Hi Max, just checking in on your progress. Is everything going okay? Thanks.
Max Romanchenko
Amrayu78 Hi Duong,
I'm fine, thank you. I apparently added a comment in the wrong place 4 days ago and you were not notified about it (see screenshot in this thread). Sorry about that.
Amrayu78
Max Romanchenko: Hi Max, do you have the link to the original comment? The screenshot is too small to look at the screenshot embedded in the screenshot lol
Thank you!
Max Romanchenko
Amrayu78
Sure, here's a comment (it's the first comment at the top of this discussion):
In general terms, I have completed this functionality.
- I completely changed the logic for adding, editing and displaying locations on the drama/movie/special/people/group pages. I also changed some styles for all relationship forms.
- I added a new “Add Oshi Spot” page and put the form on it.
- I created a template for the Oshi Spot page and added all the necessary information and functionality to it.
Please check.
I also have a question. What exactly are the image fields that need to be filled in / displayed? There are a lot of them....(see screenshot).
Second question. The Oshi index page also needs to be improved, right?
Amrayu78
Max Romanchenko: Thanks Max.
Let's use the Caption field.
Yes, Oshi Index will need to be improved too. I will mock it up for you after I test this.
Amrayu78
Max Romanchenko: Still testing, but here's a minor change for Drama, Movies, SPs, People, and Group pages. Screenshot attached.
Amrayu78
Max Romanchenko: Oshi Spot page looks good so far. Some minor fixes.
For Dates...
Dramas, SPs: Dates: Jan 2, 2024 - Feb 2, 2024
Movies: Release date: Jan 2, 2024
People: Birthdate:
Groups: Debut Year:
Amrayu78
Max Romanchenko: Fixes for Oshi Spots Index. Featured image should be from Oshi Spot page.
Max Romanchenko
Amrayu78 Hi Duong,
I've made all the corrections. Check it out, please.
My comments.
Instead of “???” (when the episodes field is empty) I displayed “N/A” (to make it consistent with other pages).
Instead of the “birthday” label, I displayed “Born” (to be consistent with the person's page).
Amrayu78
Max Romanchenko: Thanks!
We're almost there and done with this part of the feature.
Minor fix for index attached as screenshot.
Also this oshi spot has a critical error: https://drama-otaku.com/oshi-spot/obitsuzeki-park/
Amrayu78
Max Romanchenko: I tried adding 2 oshi spots to a drama and looks like there's some issues.
- Added new Oshi spot: https://drama-otaku.com/oshi-spot/koenji-junjo-shotengai-pure-heart-shopping-street/
- From this Oshi Spot, added related Drama and details
- Checked the Related Drama page: https://drama-otaku.com/drama/munou-no-taka/#oshi-spots
- Check screenshot for issue.
Max Romanchenko
Amrayu78 I fixed all the bugs.
Check it out, please.
I didn't quite understand about the drama/movie/special/person/group title on the Oshi Spot Index page. I moved it to the top and the post type label underneath it. Is that right?
Please let me know if I'm missing anything.
Amrayu78
Max Romanchenko: just checked and looks good. Another bug I found. Go to a drama page with oshi spot like Munou no Taka. Check the first item for Tokyo Station - the gallery only shows one image in mobile view.
Max Romanchenko
Amrayu78 That's weird. Couldn't reproduce the bug, however I think the slider doesn't have enough space when the screen is small. I set “slidesPerView: 1” for small screens. Please check.
Amrayu78
Max Romanchenko: It looks better now! I think there may be some cache since I only see image when I slide to the next image.