Oshi Shrine for Person pages
complete
Amrayu78
Mockup for Person page (this is for after Oshi Shrine is done):
Here's the mockup for the Person page: https://www.canva.com/design/DAGq2ghQkas/3MnijdT_AMm50XlRf99WOA/view?utm_content=DAGq2ghQkas&utm_campaign=designshare&utm_medium=link2&utm_source=uniquelinks&utlId=h9722281dc5
New field: Known for:
There's some titles where it made the person super popular.
I'm attaching a screenshot from IMDB which features this.
New feature: Known for "Credit" tag.
Please check the Canva mockup for updated notes. Screenshot also attached.
Amrayu78
complete
Amrayu78
closed
Amrayu78
Max Romanchenko: I'm splitting the Person page away from the Oshi Shrine canny so it's not confusing and overwhelming. Feel free to work on this after the Shrine is done.
Max Romanchenko
Amrayu78
Thank you for the screenshot and details.
I decided to work on this first because it's a separate task. It's done. This field searches for the title in a person's cast (cast, crew, music). Please check it.
Amrayu78
Max Romanchenko I've tested it and it's working as expected. Thank you! I may ask for one more minor update related to the People pages. I will update the main post above with this new minor update.
Max Romanchenko
Amrayu78
In the form:
I added a new field for the Primary Term.
The default status is None (not selected).
You need to resave all people and select the necessary term. This solution will also be compatible with Oshi Shrine in the future.
On the person's page:
The primary term will be highlighted in color and marked with a star with tooltip text. This primary term will be excluded from the list of selected terms to avoid duplication (but all terms will still be stored in the database). I think this is a reasonable solution, what do you think?
Please check it out.
Amrayu78
Max Romanchenko: I've checked this on two people and it's working as expected.
Since we have a lot of people this will take a lot of time to swap these over. Can you help with the migration of this data to the new primary term?
If a person has only 1 credit tag selected, that is their primary term. For the people that have none or two, please provide a list and I will go through and work on those manually.
Thanks.
Amrayu78
Max Romanchenko I have one question though, what if someone selects a primary term and it's not tagged in credits? What happens then?
Amrayu78
Max Romanchenko: In Advanced Search, I selected Singer and typed in the name Kimura Takuya.
No one comes up. I added the Known for credit tag "singer" to his profile to test this.
Max Romanchenko
Amrayu78
Since we have a lot of people this will take a lot of time to swap these over. Can you help with the migration of this data to the new primary term?
–– Of course, I can help.
If a person has only 1 credit tag selected, that is their primary term. For the people that have none or two, please provide a list and I will go through and work on those manually.
–– Ok. I need to write a migration script. I'll let you know when it's ready.
What if someone selects a primary term and it's not tagged in credits? What happens then?
–– In that case, I can try to make some kind of warning that you first need to choose a credit term.
Max Romanchenko
Amrayu78 This does not work because Singer is selected as the primary term, but Singer is not selected in the credits.
Max Romanchenko
It would be great to display only those terms in the “Known for Credit tag” field that are selected in the Credits field above.
I'll think about it.
Amrayu78
Max Romanchenko I think this would be the ideal solution.
Amrayu78
Max Romanchenko This will be double work in some cases then. Can you add logic where the dropdown is only pulled from the credits field? I definitely feel like people will add the known for credit tag and expecting it to populate the credits field.
Max Romanchenko
Amrayu78 Okay, it turned out to be quite challenging.
However, I believe everything worked out, and now the process is smoother.
–– I refactored the Primary Term field (please check it).
- If a person has only 1 credit tag selected, that is their primary term.
–– Done.
- For the people that have none or two, please provide a list and I will go through and work on those manually.
–– Done. Here is the link:
Amrayu78
Max Romanchenko: This is working as expected! Thank you.
Can you migrate some more? The list is quite long hahaha.
If a person has 2 or more (and one of the credits is actor/actress) and they have 16 or more titles associated, then mark them as an actor/actress.
If a person has 2 or more (and one of the credits is actor/actress and singer) and they have 15 or less titles associated, mark them as a singer.
After this, can you send me the updated list?
Thank you.
Max Romanchenko
Amrayu78 I have completed this migration:
"If a person has 2 or more (and one of the credits is actor/actress) and they have 16 or more titles associated, then mark them as an actor/actress.
If a person has 2 or more (and one of the credits is actor/actress and singer) and they have 15 or less titles associated, mark them as a singer."
Here is a link to the people who were updated during this migration:
Here is an updated list of people who have not yet been assigned a Primary Term:
Amrayu78
Max Romanchenko Thanks! This saves us some time.
Max Romanchenko
Amrayu78 Glad to help!
I also added this field to the admin panel for People posts with adapted logic for WordPress checkboxes. In case adding/editing a person will not happen in the frontend.
Max Romanchenko
Amrayu78 I am moving forward with the people template.
I made a responsive slider from of person's photo with caption support. I also removed the media tab from the people pages.
Please check it out.
Max Romanchenko
Amrayu78 I have a question about the sections “Featured Oshi Shrines,” “Recent Oshi Timeline Moments,” and “Top Fans.”
Can you describe each section in more detail pleae? Are these sections in the context of the current person, or not?
Thank you!
Amrayu78
Max Romanchenko These are related to the current person. This isn't a global thing (sitewide).
Max Romanchenko
Amrayu78 Thank you for your answers.
I have some questions about the Become a Fan button (see screenshot).
Am I correct in thinking that this button is the same as Adopt Oshi?
Or does it not offer instant prompt creation of Oshi?
Amrayu78
Max Romanchenko: You're right, it should be "Adopt Oshi"
Max Romanchenko
Amrayu78 So this is an exact copy of the button above?
Amrayu78
Max Romanchenko Yup. I'm just worried if people will see the button or not. Maybe after seeing all the featured shrines, content, etc, they want to adopt the oshi.
Max Romanchenko
Amrayu78 Got it! Thanks.
Amrayu78
Max Romanchenko A few cosmetic updates.
Max Romanchenko
Amrayu78 Done. Please check.
Amrayu78
Max Romanchenko "about" update looks good. But the gray border seems to be missing from the oshi stuff on the page.
Max Romanchenko
Amrayu78 Fixed
Amrayu78
Max Romanchenko Some more changes/fixes.
Max Romanchenko
Amrayu78I hide the entire About section if there is no content. I think it's better that way, right?
Max Romanchenko
Amrayu78Sorry, I wrote about the same thing, LOL.
Amrayu78
Max Romanchenko Yup, that's what I wanted. Thank you.
Amrayu78
Max Romanchenko
If a person has no oshi content, then only show 1 ad.
Currently, it's showing 2 ads and that's a bit much.
Max Romanchenko
Amrayu78 Thank you for your attention, you are right. I have fixed it.
Amrayu78
Max Romanchenko Thanks!
Amrayu78
Max Romanchenko I think this feature is complete now right? If yes, I will announce to the users today. Thank you so much!
Max Romanchenko
Amrayu78 Yes, this part is ready. There's just one small detail left (please see the screenshot), although this is more related to the new ticket - Oshi Shrine Archive.
This link currently leads to the Oshi Shrine Archive. I think that's correct, but it needs to lead to an archive sorted by the number of Nyans, right? Question: can we make two types of sorting on the Oshi Shrine archive page (or is one enough)?
- By number of Nyans
- By number of Views.
I just think that at first, not all Shrines will have Nyans (this will narrow down the results).
I'm waiting for a mockup of the archive for Oshi Shrine, if you have the time.
Amrayu78
Max Romanchenko I commented about this exact thing on the other ticket. Check my latest comment there. There's also a mockup. Thanks.
Max Romanchenko
Amrayu78 Thank you. I'm working on it.
Amrayu78
Max Romanchenko I'll close out this ticket since it's getting long. I'll open up new tickets if we have more changes.