Add new languages as Subtitle options
complete
Amrayu78
I've added the following languages as a new tag on Subtitle Projects:
- Spanish (LA) (LA = Latin America)
- Spanish (ES) (ES = Country code for Spain)
It's showing up in Subtitle Projects as a dropdown now, but please update the other views that this may show up including, but not limited to...
- Treasure Island, dropdown, Listed under Subtitle Projects (Spanish - Latin America, Spanish (Spain))
- Add Fansub Language option for Fansubber Profiles - https://drama-otaku.com/subtitle-provider/sars-fansubs/. I want Fansubbers to start tagging their profiles to show which languages they specialize in. This can be multiple languages that they translate/fansub in.
- Frontpage "Current Subtitles" badges -- [Spanish (LA)] and [Spanish (ES)] badges (yellow for both)
- Archives -- update the badges -- [Spanish (LA)] and [Spanish (ES)] badges (yellow for both)
- Advanced Search - https://drama-otaku.com/advanced-search/ -- Subtitles tab: Looks like the option to select Spanish is there already. We just want to make sure that Subtitles in Spanish show up in Advanced Search.
- Subtitles (top nav item) -- Add Spanish (LA) and Spanish (ES): Page for reference (English) https://drama-otaku.com/subtitle-language/english/
I might've missed some other areas on the site that need to be updated, so please check the code for other references.
Amrayu78
marked this post as
complete
Amrayu78
Max Romanchenko Please also add the relevant flag on Subtitle Project pages too.
Spanish (ES) = Spain flag
Spanish (LA) = Mexico flag
Amrayu78
Max Romanchenko Enhancement for you.
Max Romanchenko
Amrayu78 I've added flags everywhere.
I have some questions.
- Treasure Island. Question about the dropdown. Currently, the filter has the following options:
All
English only
Japanese only
Both
I'm not sure how it should look now with two new languages.
- Is the language for Fansubber Profiles a new taxonomy? I mean, we currently have a subtitle language taxonomy. Do we need to create a new one for Providers so as not to mix the results?
If we make the taxonomy shared between projects and providers, then the archive
will display both projects and providers.
- Archives - Currently, the color for English and Japanese tags is gray. Should it be changed to yellow for Spanish? Please check the current implementation (for example, the Advanced Search page).
Amrayu78
Max Romanchenko
- Treasure Island > Lump both Spanish together - Spanish only (LA & ES)
Both < get rid of Both
- Is the language for Fansubber Profiles a new taxonomy? I mean, we currently have a subtitle language taxonomy. Do we need to create a new one for Providers so as not to mix the results? -> Hm, I think it's fine to mix the two? Because users may want to find fansubbers who only subtitle in Spanish.
- Archives - Can we change the colors for English, Japanese, Spanish so we have more of a cohesive feel for all the tags?
Thanks!
Max Romanchenko
Amrayu78 All Done. I've added the same taxonomy (subtitle language) to the provider form.
Amrayu78
Max Romanchenko For Treasure Island, does it make sense to have these options as checkboxes instead? Then users can filter by what they want.
So a dropdown with checkboxes, then we can separate out the Spanishes too (into LA and ES).
Max Romanchenko
Amrayu78 To clarify the subtitle filter changes:
Current system (exclusive matching an unusual filter, but that's exactly what we wanted in the past):
- "English only" = Shows ONLY dramas with EXACTLY 'en' subtitles (no other languages)
- "Japanese only" = Shows ONLY dramas with EXACTLY 'jp' subtitles
Results are limited to exact matches only
New checkbox filter (inclusive matching):
- "English" = Shows dramas that CONTAIN 'en' subtitles (can have other languages too)
- "Japanese" = Shows dramas that CONTAIN 'jp' subtitles (can have other languages too)
Multiple selections allowed (e.g., English + Spanish LA + Spanish ES)
Results will be broader/more inclusive. Selecting "English" will show MORE results in the checkbox system vs. "English only" in the current system.
Do you want to switch to the checkbox system with this new inclusive logic? This changes how filtering works and what results users will see.
Amrayu78
Max Romanchenko Can we make the checkbox filter do exclusive matching?
So it'll only do the following:
- English only
- Japanese only
- Spanish only
Then it'll behave like before? I don't quite understand why switching the UI would result in this difference in logic?
Max Romanchenko
Amrayu78 Absolutely! We can make the checkbox filter use exclusive matching too.
I apologize, apparently the mention of checkboxes made me think that the filtering logic needed to be changed as well.
How it would work with checkboxes (exclusive matching):
-English only = Shows ONLY dramas with EXACTLY English subtitles (no other languages)
-Japanese only= Shows ONLY dramas with EXACTLY Japanese subtitles
-Spanish LA only = Shows ONLY dramas with EXACTLY Spanish LA subtitles
-Spanish ES only = Shows ONLY dramas with EXACTLY Spanish ES subtitles
If you check both "English only" and "Japanese only", it will show dramas with EXACTLY English AND Japanese (no other languages) - same as old "Both" option.
If you check "English only", "Japanese only", and "Spanish LA only" - it will show dramas with EXACTLY those 3 languages (no others).
Does this match what you want? Should Spanishes be separated (into LA and ES)?
Amrayu78
Max Romanchenko Yes this matches my expectations.
Yes you can separate out the Spanishes, since I lumped them together when it was the other dropdown UI.
Max Romanchenko
Amrayu78 I've made some changes to the display and logic of the filter. Please check.
Amrayu78
Max Romanchenko This is working well. Thanks!